Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression: Infinite render loop on Setup Wizard #18074

Merged
merged 1 commit into from
Jun 29, 2020
Merged

Regression: Infinite render loop on Setup Wizard #18074

merged 1 commit into from
Jun 29, 2020

Conversation

tassoevan
Copy link
Contributor

Proposed changes

One of the dependencies of an effect on SettingsBasedStep is a callback continuously updated by the own effect, which resets the whole form state. Its PR fixes that by making the callback stable, i.e., not changing at every update.

Issue(s)

Closes #18060

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Further comments

@tassoevan tassoevan requested review from rodrigok, sampaiodiego and a team June 29, 2020 21:45
@ggazzo ggazzo changed the title [FIX] Infinite render loop on Setup Wizard Regression: Infinite render loop on Setup Wizard Jun 29, 2020
@ggazzo ggazzo added this to the 3.4.0 milestone Jun 29, 2020
@ggazzo ggazzo merged commit fa32fea into develop Jun 29, 2020
@ggazzo ggazzo deleted the fix/infinite-effect-loop branch June 29, 2020 23:06
gabriellsh added a commit that referenced this pull request Jun 30, 2020
@gabriellsh
Merge branch 'new/account_sidebar_rewrite' of github.com:RocketChat/R…
7de66a7 
…ocket.Chat into new/rewrite_account_profile

* 'new/account_sidebar_rewrite' of github.com:RocketChat/Rocket.Chat:
  Fix sidenav close
  Regresion: Issue with reply button on broadcast channels (#18057)
  Regression: Infinite render loop on Setup Wizard (#18074)
  Regression: Improve Omnichannel Business Hours (#18050)
  Regression: Fix threads badge color indicators (#18048)
  Regression: Improve the logic to get request IPs (#18033)
@sampaiodiego sampaiodiego mentioned this pull request Jun 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dudizilla dudizilla dudizilla approved these changes

@rodrigok rodrigok Awaiting requested review from rodrigok

@sampaiodiego sampaiodiego Awaiting requested review from sampaiodiego

Assignees
No one assigned
Labels
type: bug ui/ux
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.

Component client/views/setupWizard/steps/SettingsBasedStep.js re-renders indefinite times
3 participants
@tassoevan @dudizilla @ggazzo